Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdf4store: remove pkg and service modules #74214

Merged
merged 1 commit into from Dec 8, 2019
Merged

rdf4store: remove pkg and service modules #74214

merged 1 commit into from Dec 8, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 25, 2019 •
edited

Motivation for this change

As of today the 4store pkg (rdf4store attribute) :

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

@c0bw3b c0bw3b added this to To do in Picking up garbage via automation Dec 5, 2019
@c0bw3b c0bw3b moved this from To do to In progress in Picking up garbage Dec 5, 2019
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Dec 8, 2019

@7c6f434c > are you ok with this removal?

@7c6f434c
Copy link
Member

7c6f434c commented Dec 8, 2019

Yes, Apache Jena is enough for whenever I need RDF. Somehow missed the original mention, sorry.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Dec 8, 2019

No problem, thanks

@c0bw3b c0bw3b merged commit f640cf4 into NixOS:master Dec 8, 2019
Picking up garbage automation moved this from In progress to Done Dec 8, 2019
@c0bw3b c0bw3b deleted the rem/4store branch December 8, 2019 19:33
c0bw3b added a commit that referenced this pull request Dec 21, 2019
@c0bw3b
rdf4store: throw removal messages
b1b55ba 
Addition to #74214
I forgot to add aliases for package and modules after removal
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 19, 2020
@c0bw3b @dtzWill
rdf4store: throw removal messages
8e356b7 
Addition to NixOS#74214
I forgot to add aliases for package and modules after removal

(cherry picked from commit b1b55ba)
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 11, 2020
@c0bw3b @dtzWill
rdf4store: remove pkg and service modules
b384234 
(NixOS#74214)

(cherry picked from commit f640cf4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @7c6f434c