Nixos test containers python port #74218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test containers-bridge containers-ipv4 containers-ipv6 |
flokli
reviewed
Nov 26, 2019
nixos/tests/containers-ipv4.nix
Outdated
| chomp $ip; | ||
| $machine->succeed("ping -n -c1 $ip"); | ||
| $machine->succeed("curl --fail http://$ip/ > /dev/null"); | ||
| with subtest("wait 2s for container to start and network to be up"): |
There was a problem hiding this comment.
I think we shouldn't overdo with grouping things into subtests. This should really be just a comment. ;-)
tfc
force-pushed
the
nixos-test-containers-python-port
branch
2 times, most recently
from
e528601
to
1479e03
Compare
|
@GrahamcOfBorg test containers-bridge containers-ipv containers-imperative |
tfc
force-pushed
the
nixos-test-containers-python-port
branch
from
1479e03
to
f58088c
Compare
|
@GrahamcOfBorg test containers-bridge containers-ip containers-imperative |
tfc
force-pushed
the
nixos-test-containers-python-port
branch
from
f58088c
to
b1e9e7c
Compare
|
@GrahamcOfBorg test containers-bridge containers-ip containers-imperative |
tfc
force-pushed
the
nixos-test-containers-python-port
branch
from
b1e9e7c
to
9de0a8a
Compare
|
@GrahamcOfBorg test containers-bridge containers-ip containers-imperative |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @flokli @worldofpeace @Lassulus