New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kicad: cleanup, fix and update #74259
Conversation
aa3b108
to
0bb9895
Compare
Does this PR address the issue with kicad not finding the new libraries after updating? I.e., right now
Even if you update kicad, it still looks for footprints, etc. in the old path. |
with this PR i add those paths to the wrapper |
20eee28
to
88e245a
Compare
008099c
to
2f5beb1
Compare
490b538
to
7f58be1
Compare
7f58be1
to
259c56d
Compare
7ed5e76
to
9761522
Compare
9761522
to
0b4b1df
Compare
This is needed for python scripting support.
use wxGTK31 brings hiDPI support no python shell...
make unstable use kicad-libraries still using a link in $out..., not sure that's a bad thing this allows setting that path in makeWrapperArgs can't use $out there kicad-with-packages3d -> kicad and kicad-small default to OCCT, OCE is outdated enforce OCCT on aarch64, where OCE is broken withOCE flag allows using OCE on non-aarch64
switch source to gitlab as that's the new upstream source use wrapper variables for everything but i18n add sym and fp templates to template path update meta to reflect kicad's own language set license to AGPLv3, according to the source's LICENSE.README reduce diff between default and unstable in preparation of merging on debian gets "no module named 'math'" pcbnew 3d viewer is unusable (at least on my T410)
use latest libraries for unstable move all revs and hashes to default.nix thanks TQ for getting me through this blockage
minor simplification, fix base version split i18n and get from gitlab correct wrapper pythonpath, cleanup build output update & fake git describe correct base.nix to fit contributing.md
Works for me. I can confirm that the issue with the stale paths is resolved now. @evils-devils Is this ready to merge? (I think the remaining todos should be done in follow-up PRs.) |
@gebner as this is a rather large overhaul, i wouldn't mind a bit more confirmation that i didn't violate some convention (i can't find any other package using the approach i ended up with). I do believe it's ready to merge (though i'm about to force push the latest unstable hashes, after i confirm it they work) As i don't know how to fix the remaining things i'd like done, should i open an issue for those? |
This PR has now been open for a few months. If somebody had a strong opinion, they would have commented by now. Since this fixes a lot of issues with kicad, I'm going to merge it. Feel free to open issues for the remaining todo items if you want. |
Sorry, completely missed this part. Please make a new PR for the updated unstable hashes. |
Motivation for this change
fixes #72248
fixes #49090
includes / closes #72813
affected by #73145, #39493
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)kicad-with-packages3d
to newkicad
)kicad
vs newkicad-small
)kicad
vs newkicad
, now includes the 3D packages)kicad-unstable
)debug = true;
start from kicad: python2 -> python3 #72813
separate the building in base.nix
separate the libraries' definitions in libraries.nix
separate derivations, reused for kicad-small
a bunch of wrapping in default.nix
make kicad have the 3D packages by default
add kicad-small to preserve the original kicad behaviour of not including the 3D packages (5gb)
fix kicad-unstable
Status
kicad from nix on debian
no module named 'math'
goes away in anix-shell --pure
, how replicate this behaviour in an installation?figure out what meta.platforms to set (kicad is cross-platform)
aarch64 builds by using opencascade-occt
file chooser not getting the icon for *.pro
5.1.x fails 1 test (eeschema)
kicad-small (without 3D models), should it be?
unstable
pname
and using that to switch the sources and some other stuffnice-to-haves
reminders to self, before undrafting, do:
Notify maintainers
cc @berce
and @Kiwi who was added (on their request) as a maintainer