Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coq: Fix setup hook #74153

Merged
merged 1 commit into from Nov 25, 2019
Merged

coq: Fix setup hook #74153

merged 1 commit into from Nov 25, 2019

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Fix #74083

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vbgl
Copy link
Contributor

vbgl commented Nov 25, 2019

@GrahamcOfBorg build satallax framac

@Ericson2314 Ericson2314 merged commit 52665a7 into NixOS:master Nov 25, 2019
@Ericson2314 Ericson2314 deleted the fix-coq branch November 25, 2019 20:55
@vbgl vbgl mentioned this pull request Jan 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roconnor roconnor Awaiting requested review from roconnor

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@vbgl vbgl Awaiting requested review from vbgl

@Zimmi48 Zimmi48 Awaiting requested review from Zimmi48

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nix-shell with coq+compcert will not start
2 participants
@Ericson2314 @vbgl