Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud: 17.0.0 -> 17.0.1 #74152

Merged
merged 1 commit into from Nov 25, 2019
Merged

nextcloud: 17.0.0 -> 17.0.1 #74152

merged 1 commit into from Nov 25, 2019

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dasJ
Copy link
Member

dasJ commented Nov 25, 2019

@GrahamcOfBorg build nextcloud
@GrahamcOfBorg test nextcloud

@ofborg ofborg bot requested review from globin, schneefux and fpletz November 25, 2019 14:44
jonringer
jonringer approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commit LGTM
patch bump

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74152
1 package were built:
nextcloud

@jonringer jonringer merged commit 03fef7c into NixOS:master Nov 25, 2019
@ajs124 ajs124 deleted the upd/nextcloud_17.0.1 branch November 25, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@globin globin Awaiting requested review from globin

@schneefux schneefux Awaiting requested review from schneefux

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @dasJ @jonringer