nixos/kubernetes: allow configuring cfssl API server SANs #74094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping @calbrecht @globin |
|
Hey @jonringer, pinging you on this one for a review, feel free to ignore if it's too out of your depth. |
jonringer
reviewed
Jan 16, 2020
| @@ -20,6 +20,7 @@ let | |||
| size = 2048; | |||
| }; | |||
| CN = top.masterAddress; | |||
| hosts = cfg.cfsslAPIExtraSANs; | |||
There was a problem hiding this comment.
would be nice to have a tests which demonstrates that this gets correctly used
|
also, i think the commit/PR name should be: |
infinisil
reviewed
Jan 16, 2020
| description = '' | ||
| Extra x509 Subject Alternative Names to be added to the cfssl API webserver TLS cert. | ||
| ''; | ||
| default = []; |
|
Thanks for the initial review. I did the following things:
I can look into adding a test next, but it might take me a while to do that. |
|
please squash commits |
|
Done |
anmonteiro
changed the title
jonringer
approved these changes
Jan 19, 2020
There was a problem hiding this comment.
this seems to correspond with official documentation https://kubernetes.io/docs/tasks/tls/managing-tls-in-a-cluster/#create-a-certificate-signing-request
LGTM
|
@GrahamcOfBorg test kubernetes.dns |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
services.kubernetes.easyCertsis really useful to bootstrap a Kubernetes cluster. A common use case in Kubernetes clusters is to have a DNS entry for the master so that nodes can connect to a master that may change address (e.g. in an autoscaling group).Right now this is not easily possible because the master also runs the cfssl API server but doesn't allow registering Subject Alternative Names in its TLS cert.
This PR proposes allowing configuring the extra SANs in this certificate similarly to what's available in the API server:
nixpkgs/nixos/modules/services/cluster/kubernetes/apiserver.nix
Lines 139 to 143 in a3465d9
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @johanot @calbrecht (apologies if spammy, this is my first contribution to nixpkgs and you both were listed as the top committers in
pki.nix)