Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: 0.3.3 -> 0.4.0 #74187

Merged
merged 2 commits into from Nov 26, 2019
Merged

alacritty: 0.3.3 -> 0.4.0 #74187

merged 2 commits into from Nov 26, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 25, 2019 •
edited

Also:

  • remove postPatch (config is not generated anymore; i.e. there's no mouse.rs or xdg-open mentions anywhere
Motivation for this change

https://github.com/jwilm/alacritty/releases/tag/v0.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

This change is Reviewable

@Br1ght0ne
alacritty: 0.3.3 -> 0.4.0
c8ca52c 
Also:
- remove postPatch (config is not generated anymore;
  i.e. there's no `mouse.rs` or `xdg-open` mentions anywhere
@Br1ght0ne
alacritty: add filalex77 to maintainers
8ef50f1
@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg build alacritty

@ofborg ofborg bot requested a review from Mic92 November 25, 2019 20:07
@Br1ght0ne
Copy link
Member Author

Would be great if somebody ran a build on Darwin (and merged, probably) ;)

@Ma27 Ma27 merged commit ad80b0a into NixOS:master Nov 26, 2019
@Mic92
Copy link
Member

Mic92 commented Nov 27, 2019

@GrahamcOfBorg build alacritty

@Br1ght0ne
Copy link
Member Author

@Mic92 Probably doesn't work because the PR is merged. Oh well, we'll just have to wait and see :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Br1ght0ne @Mic92 @grahamc @Ma27