New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pantheon updates 2019-11-25 #74243
Merged
worldofpeace
merged 16 commits into
NixOS:master
from
worldofpeace:pantheon-updates-2019-11-25
Dec 1, 2019
Merged
Pantheon updates 2019-11-25 #74243
worldofpeace
merged 16 commits into
NixOS:master
from
worldofpeace:pantheon-updates-2019-11-25
Dec 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: pantheon
The Pantheon desktop environment
11.by: package-maintainer
10.rebuild-darwin: 0
10.rebuild-linux: 11-100
labels
Nov 26, 2019
worldofpeace
force-pushed
the
pantheon-updates-2019-11-25
branch
from
November 26, 2019 14:08
9306100
to
942cf07
Compare
Sometimes I get rate limited.
Now uses meson build system 💖. https://github.com/elementary/wallpapers/releases/tag/5.5.0
worldofpeace
force-pushed
the
pantheon-updates-2019-11-25
branch
from
December 1, 2019 22:48
942cf07
to
82223a7
Compare
There are really becoming a pain to maintain.
We submitted a patch upstream to fix this.
worldofpeace
force-pushed
the
pantheon-updates-2019-11-25
branch
from
December 1, 2019 22:56
82223a7
to
8d29ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: pantheon
The Pantheon desktop environment
10.rebuild-darwin: 0
10.rebuild-linux: 11-100
11.by: package-maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Aside from the updates this mainly changes how I'm handling gsettings schemas in the switchboard plugs. Instead of using hardcode patches, we're now going to create the appropriate wrapper in
wrapper.nix
by makingswitchboard-with-plugs
having allbuildInputs
of the plugs and the plugs themselves inbuildInputs
. We then run the glib setup hook and execute wrapGAppsHook normally.This is a similar idea to what was happening in
wingpanel
, just executed better.I choose this route because I cannot generate semantic patches like we've done with Coccinelle, and that's entirely because they're in Vala and not C. (which is a ++ in my opinion).
I won't have to hold a bunch of downstream patches that I have to resync or rewrite entirely.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @