Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon updates 2019-11-25 #74243

Merged
merged 16 commits into from Dec 1, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Aside from the updates this mainly changes how I'm handling gsettings schemas in the switchboard plugs. Instead of using hardcode patches, we're now going to create the appropriate wrapper in wrapper.nix by making switchboard-with-plugs having all buildInputs of the plugs and the plugs themselves in buildInputs. We then run the glib setup hook and execute wrapGAppsHook normally.
This is a similar idea to what was happening in wingpanel, just executed better.

I choose this route because I cannot generate semantic patches like we've done with Coccinelle, and that's entirely because they're in Vala and not C. (which is a ++ in my opinion).
I won't have to hold a bunch of downstream patches that I have to resync or rewrite entirely.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace merged commit bb10135 into NixOS:master Dec 1, 2019
@worldofpeace worldofpeace deleted the pantheon-updates-2019-11-25 branch December 1, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant