Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudatoolkit: add 10.1.243 #68954

Merged
merged 3 commits into from Nov 6, 2019
Merged

cudatoolkit: add 10.1.243 #68954

merged 3 commits into from Nov 6, 2019

Conversation

dguibert
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @knedlsepp @danieldk

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-are-your-goals-for-19-09/2875/38

@danieldk
Copy link
Contributor

Thanks! I'll try to test this on a non-NixOS system today.


gcc = gcc7;
};

cudatoolkit_10 = cudatoolkit_10_0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to default to cudatoolkit_10_1 here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -2473,7 +2473,8 @@ in
cudatoolkit_9_1
cudatoolkit_9_2
cudatoolkit_10
cudatoolkit_10_0;
cudatoolkit_10_0
cudatoolkit_10_1;

cudatoolkit = cudatoolkit_9;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be time to bump that one to cudatoolkit_10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@danieldk
Copy link
Contributor

I couldn't test Tensorflow (I have to recompile it with CUDA 10.1), but CUDA and CuBLAS seem to work well on Ubuntu 18.04 with this PR.

@dguibert
Copy link
Member Author

I couldn't test Tensorflow (I have to recompile it with CUDA 10.1), but CUDA and CuBLAS seem to work well on Ubuntu 18.04 with this PR.

I've also update cudnn.

@FRidh FRidh added this to the 19.09 milestone Sep 18, 2019
Copy link
Member

@disassembler disassembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. If this is ready, lets merge and cherry pick into 19.09. We're trying to close out all open issues in the milestone this week.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/building-with-cuda-on-nixpkgs/4462/5

@knedlsepp
Copy link
Member

@disassembler Would you mind merging this?

@knedlsepp
Copy link
Member

@andir Could you take a look?

@andir
Copy link
Member

andir commented Nov 5, 2019

@knedlsepp Looks good. All those now optional build steps are no longer required because they cleaned up their build system?

@knedlsepp
Copy link
Member

@knedlsepp Looks good. All those now optional build steps are no longer required because they cleaned up their build system?

Yes, cudatoolkit 10.1 is actually rather straightforward to package. (I can proof that: I did package it independently from this PR starting from a clean slate: knedlsepp@630068e )

@andir andir merged commit 1e72fa5 into NixOS:master Nov 6, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
cudatoolkit: add 10.1.243
(cherry picked from commit 1e72fa5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants