cudatoolkit: add 10.1.243 #68954
cudatoolkit: add 10.1.243 #68954
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/what-are-your-goals-for-19-09/2875/38 |
ofborg
bot
added
8.has: package (new)
|
Thanks! I'll try to test this on a non-NixOS system today. |
|
|
||
| gcc = gcc7; | ||
| }; | ||
|
|
||
| cudatoolkit_10 = cudatoolkit_10_0; |
There was a problem hiding this comment.
We probably want to default to cudatoolkit_10_1 here.
pkgs/top-level/all-packages.nix
Outdated
| @@ -2473,7 +2473,8 @@ in | |||
| cudatoolkit_9_1 | |||
| cudatoolkit_9_2 | |||
| cudatoolkit_10 | |||
| cudatoolkit_10_0; | |||
| cudatoolkit_10_0 | |||
| cudatoolkit_10_1; | |||
|
|
|||
| cudatoolkit = cudatoolkit_9; | |||
There was a problem hiding this comment.
Might be time to bump that one to cudatoolkit_10
|
I couldn't test Tensorflow (I have to recompile it with CUDA 10.1), but CUDA and CuBLAS seem to work well on Ubuntu 18.04 with this PR. |
I've also update cudnn. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/building-with-cuda-on-nixpkgs/4462/5 |
|
@disassembler Would you mind merging this? |
|
@andir Could you take a look? |
|
@knedlsepp Looks good. All those now optional build steps are no longer required because they cleaned up their build system? |
Yes, cudatoolkit 10.1 is actually rather straightforward to package. (I can proof that: I did package it independently from this PR starting from a clean slate: knedlsepp@630068e ) |
cudatoolkit: add 10.1.243 (cherry picked from commit 1e72fa5)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @knedlsepp @danieldk