New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faudio, wine, vkd3d: add faudio 19.10 and vkd3d 1.1 to wine #68952
Conversation
There is a problem when I try to replace rev = "19.09" by rev = version, saying this variable does not exist. |
On Wed, Sep 18, 2019 at 01:18:05AM -0700, marius851000 wrote:
There is a problem when I try to replace rev = "19.09" by rev = version, saying this variable does not exist.
`stdenv.mkDerivation rec {` for that.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks ok for me (I add two suggestions).
Local building in progress, although I don't know how to test if faudio really works (I can test only if my usual stuff works)
Based on what I found, it also concern an XCOM game. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except minor formatting issues, is looking good for me
@marius851000 I never tried xcom in wine. (only native openxcom, but it a bit different thing).. If you have vulkan capable video (and dx12 capable game) you welcomed to add vk3d support as well (but vk3d.nix should go into wine's subdir, because it meaningless outside wine) -- I can't do it myself, because I haven't vk capable video to test. (or if you willing to test -- I can do it myself) |
@avnik That's a good idea (I've a lot of free time actually). Will work on it. |
I found that retroarch can use xaudio (it may be needed to enable it in the driver option menu. Can't test it where I am) |
I need help, as vkd3d have no compilation problem, but wine has one that I don't know how to solve |
Also vk3d should be in own commit (even if not own PR, especially if a compilation problems there) |
@avnik I'll try but it may be harder due to that I'm really good with git history modification (I just uncommit the last commit with the undo button of atom) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It builds ok with wine 4.16 , and not breaking anything.
I can't check if vkd3d works (due incapable hardware),
Commit looks good also.
ofborg's meta checks worth to be fixed as well |
Ok my computer was broken for 5 day, but It is now fixed. |
I haven't tested vkd3d, but dolphin support it (will test once compilation finished) |
I runned the test suite for vkd3d, and both of them succeeded, however, d3dv12 fail at 8 tests (over around 270 000 tests). However, dolphin fail to run (I will try to investigate) |
Updated to faudio 19.10 |
I think this is something we want, even when it doesn't fully work yet, since it's off by default. |
fixes NixOS#68952 (cherry picked from commit 2718c41)
Motivation for this change
Faudio is needed for some game (for example, Spyro Reignited Trilogy)
Things done
Added the faudio package version 19.09.
Added it as an optional dependancies of wine.
Enable it when the full wine is asked
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Spyro Reignited trilogy now lauch.
Not tested on darwin (could be important, as this is a full wine dependancies)
Notify maintainers
cc @avnik @bendlas