Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faudio, wine, vkd3d: add faudio 19.10 and vkd3d 1.1 to wine #68952

Closed
wants to merge 1 commit into from

Conversation

marius851000
Copy link
Contributor

Motivation for this change

Faudio is needed for some game (for example, Spyro Reignited Trilogy)

Things done

Added the faudio package version 19.09.
Added it as an optional dependancies of wine.
Enable it when the full wine is asked

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Spyro Reignited trilogy now lauch.
Not tested on darwin (could be important, as this is a full wine dependancies)

Notify maintainers

cc @avnik @bendlas

@marius851000
Copy link
Contributor Author

There is a problem when I try to replace rev = "19.09" by rev = version, saying this variable does not exist.

@avnik
Copy link
Contributor

avnik commented Sep 18, 2019 via email

Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks ok for me (I add two suggestions).
Local building in progress, although I don't know how to test if faudio really works (I can test only if my usual stuff works)

pkgs/development/libraries/faudio/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/faudio/default.nix Outdated Show resolved Hide resolved
@marius851000
Copy link
Contributor Author

Based on what I found, it also concern an XCOM game.

@ofborg ofborg bot requested a review from avnik September 18, 2019 18:35
Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except minor formatting issues, is looking good for me

@avnik
Copy link
Contributor

avnik commented Sep 18, 2019

@marius851000 I never tried xcom in wine. (only native openxcom, but it a bit different thing)..

If you have vulkan capable video (and dx12 capable game) you welcomed to add vk3d support as well (but vk3d.nix should go into wine's subdir, because it meaningless outside wine) -- I can't do it myself, because I haven't vk capable video to test. (or if you willing to test -- I can do it myself)

@marius851000
Copy link
Contributor Author

@avnik That's a good idea (I've a lot of free time actually). Will work on it.

@marius851000
Copy link
Contributor Author

I found that retroarch can use xaudio (it may be needed to enable it in the driver option menu. Can't test it where I am)

@marius851000
Copy link
Contributor Author

I need help, as vkd3d have no compilation problem, but wine has one that I don't know how to solve

@avnik
Copy link
Contributor

avnik commented Sep 19, 2019

Also vk3d should be in own commit (even if not own PR, especially if a compilation problems there)

@marius851000
Copy link
Contributor Author

@avnik I'll try but it may be harder due to that I'm really good with git history modification (I just uncommit the last commit with the undo button of atom)

@marius851000 marius851000 changed the title faudio, wine: add faudio 19.09 to wine faudio, wine, vkd3d: add faudio 19.09 and vkd3d 1.1 to wine Sep 20, 2019
@ofborg ofborg bot requested a review from avnik September 20, 2019 10:57
Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds ok with wine 4.16 , and not breaking anything.
I can't check if vkd3d works (due incapable hardware),

Commit looks good also.

@avnik
Copy link
Contributor

avnik commented Sep 25, 2019

ofborg's meta checks worth to be fixed as well

@marius851000
Copy link
Contributor Author

Ok my computer was broken for 5 day, but It is now fixed.

@ofborg ofborg bot requested a review from avnik September 26, 2019 06:44
@marius851000
Copy link
Contributor Author

I haven't tested vkd3d, but dolphin support it (will test once compilation finished)

@marius851000
Copy link
Contributor Author

I runned the test suite for vkd3d, and both of them succeeded, however, d3dv12 fail at 8 tests (over around 270 000 tests). However, dolphin fail to run (I will try to investigate)

@marius851000 marius851000 changed the title faudio, wine, vkd3d: add faudio 19.09 and vkd3d 1.1 to wine faudio, wine, vkd3d: add faudio 19.10 and vkd3d 1.1 to wine Oct 7, 2019
@marius851000
Copy link
Contributor Author

Updated to faudio 19.10

@bendlas bendlas closed this in 2718c41 Oct 12, 2019
@bendlas
Copy link
Contributor

bendlas commented Oct 12, 2019

I think this is something we want, even when it doesn't fully work yet, since it's off by default.

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants