Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: fix path to xdg-open #68948

Merged
merged 1 commit into from Sep 17, 2019
Merged

alacritty: fix path to xdg-open #68948

merged 1 commit into from Sep 17, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 17, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@grahamc grahamc added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 17, 2019
@ofborg ofborg bot requested a review from Mic92 September 17, 2019 02:02
jonringer
jonringer approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable works
leaf package

@Ma27 Ma27 self-assigned this Sep 17, 2019
@Ma27 Ma27 merged commit 8ba3a55 into NixOS:master Sep 17, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 17, 2019

Thanks! Backported as 97b15a4.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 17, 2019
@grahamc grahamc deleted the alacritty-xdg-open branch September 17, 2019 12:07
@grahamc
Copy link
Member Author

grahamc commented Sep 17, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@jonringer jonringer jonringer approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

@Ma27 Ma27

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @Ma27 @jonringer