Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touchups for nixos/xfce4-14 for 19.09 #68983

Merged
merged 5 commits into from Sep 19, 2019
Merged

Touchups for nixos/xfce4-14 for 19.09 #68983

merged 5 commits into from Sep 19, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Thought to do this after a bit of user feedback in #68977

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
xfceUnstable: make an alias
a8167d1 
To be removed with xfce4-12.
@worldofpeace
nixos/xfce4-14: remove gtk-xfce-engine
5bcec76 
Xfce 4.14 deprecated this.
It had many gtk2 themes that don't work that confused users NixOS#68977.
@worldofpeace
nixos/xfce4-14: add gnome-themes-extra
f85e126
@worldofpeace
nixos/xfce4-14: cleanup defaults slightly
f6398d8 
We added
- parole
- pavucontrol
- xfce4-taskmanager
- xfwm4-themes

to the default packages.
@worldofpeace worldofpeace changed the title Cleanup nixos/xfce4-14 for release Touchups for nixos/xfce4-14 for 19.09 Sep 17, 2019
ivan
ivan reviewed Sep 17, 2019
View reviewed changes
nixos/modules/services/x11/desktop-managers/xfce4-14.nix Outdated
libxfce4ui
xfconf

mousepad
parole
pavucontrol
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be included only if config.hardware.pulseaudio.enable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I wonder what program non pulseaudio users should use.

@worldofpeace worldofpeace added this to the 19.09 milestone Sep 18, 2019
@worldofpeace worldofpeace merged commit 1e6f4fb into NixOS:master Sep 19, 2019
@worldofpeace worldofpeace deleted the xfce-cleanup branch September 19, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan left review comments

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: xfce The Xfce Desktop Environment 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @ivan