Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildEnv: check pathsToLink before checking collisions #69022

Merged
merged 1 commit into from Sep 23, 2019

Conversation

lheckemann
Copy link
Member

Motivation for this change

Fixes #32683

cc @ledettwy (author of #32683), @kvz (asked me about this), @edolstra @vcunat (frequent contributors to buildEnv)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (memcached, beanstalkd, memcached, minio, ostree)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lheckemann lheckemann changed the base branch from master to staging September 18, 2019 13:14
@globin globin merged commit 6022825 into NixOS:staging Sep 23, 2019
@globin globin deleted the buildenv branch September 23, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants