Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocaml-protoc: init at 1.2.0 #68962

Merged
merged 2 commits into from Sep 20, 2019
Merged

ocamlPackages.ocaml-protoc: init at 1.2.0 #68962

merged 2 commits into from Sep 20, 2019

Conversation

vyorkin
Copy link
Member

@vyorkin vyorkin commented Sep 17, 2019 •
edited

Motivation for this change

Adds ocaml-protoc -- A Protobuf Compiler for OCaml.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I had to use the installPhase attribute to replicate some of the installation steps mentioned it the protoc's Makefile because the make install is broken for 1.2.0 (for example, there is no lib.install.byte in the Makefile that is mentioned here https://github.com/mransan/ocaml-protoc/blob/60d2d4dd55f73830e1bed603cc44d3420430632c/Makefile#L133)

vbgl
vbgl requested changes Sep 17, 2019
View reviewed changes
pkgs/development/ocaml-modules/protoc/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/protoc/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/protoc/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/ocaml-packages.nix Outdated Show resolved Hide resolved
@vyorkin vyorkin force-pushed the ocaml-protoc-1.2.0 branch 2 times, most recently from 1fdd017 to dfd5ce9 Compare September 18, 2019 07:09
@vyorkin vyorkin mentioned this pull request Sep 18, 2019
Merged
@vbgl
Copy link
Contributor

vbgl commented Sep 19, 2019 •
edited

@GrahamcOfBorg build ocamlPackages.ocaml-protoc

@vbgl vbgl changed the title ocamlPackages.protoc: init at 1.2.0 ocamlPackages.ocaml-protoc: init at 1.2.0 Sep 19, 2019
@vbgl vbgl merged commit fac7453 into NixOS:master Sep 20, 2019
@vyorkin vyorkin deleted the ocaml-protoc-1.2.0 branch December 5, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vyorkin @vbgl