Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan9port: do not use which in builder.sh #68961

Merged
merged 1 commit into from
Sep 20, 2019
Merged

plan9port: do not use which in builder.sh #68961

merged 1 commit into from
Sep 20, 2019
+1 −1

Conversation

eraserhd
Copy link
Contributor

Removing the build time dependency on which on the previous commit for
this package broke builder.sh ( my fault, sorry :( )

Motivation for this change

Make plan9port build again

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @AndersonTorres

Sorry, something went wrong.

@eraserhd
plan9port: do not use which in builder.sh

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
1a5c68c 
Removing the build time dependency on which broke builder.sh
@veprbl
Copy link
Member

veprbl commented Sep 17, 2019

@GrahamcOfBorg build plan9port

@AndersonTorres AndersonTorres merged commit 92324d9 into NixOS:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eraserhd @veprbl @AndersonTorres