Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.astropy: disable tests #68964

Closed
wants to merge 1 commit into from
Closed

python3Packages.astropy: disable tests #68964

wants to merge 1 commit into from

Conversation

smaret
Copy link
Member

@smaret smaret commented Sep 17, 2019 •
edited

Motivation for this change

python3Packages.astropy test fails with the latest python3Packages.numpy: #68361

This issue has been fixed upstream, but the latest release does not include the fix yet:
astropy/astropy#8935

Disable the tests for now so we can get python3Packages.astropy in 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @KentJames @NixOS/backports

@smaret smaret requested a review from FRidh as a code owner September 17, 2019 13:22
@d-goldin
Copy link
Contributor

@smaret: Have you tried applying the commit as a patch to see if it fixes the issue? If it works, it might be preferable to disabling the tests entirely.

@jonringer
Copy link
Contributor

duplicate of #68687

@smaret
Copy link
Member Author

smaret commented Sep 18, 2019

Closing this is as a duplicate.

@smaret smaret closed this Sep 18, 2019
@smaret smaret deleted the astropy-fix branch September 18, 2019 08:58
@d-goldin d-goldin mentioned this pull request Sep 21, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smaret @d-goldin @jonringer