Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csvs-to-sqlite: 0.9 -> 1.0 #68965

Merged
merged 1 commit into from Sep 20, 2019
Merged

csvs-to-sqlite: 0.9 -> 1.0 #68965

merged 1 commit into from Sep 20, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Sep 17, 2019

Motivation for this change

Fix the build for #68361

csvs-to-sqlite-1.0 has added support for pytest5, but dropped support for python2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" (no depend pkgs)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @costrouc

@B4dM4n B4dM4n requested a review from FRidh as a code owner September 17, 2019 14:44
@ofborg ofborg bot requested a review from costrouc September 17, 2019 14:56
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 20, 2019
@Ma27 Ma27 merged commit 6c3bf80 into NixOS:master Sep 20, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 20, 2019

Thanks! Backported as 21be135.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 20, 2019
@B4dM4n B4dM4n deleted the csvs-to-sqlite-1.0 branch September 20, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @Ma27