idid: init at 2.1.0 #68968
Closed
idid: init at 2.1.0 #68968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
mmahut
reviewed
Sep 19, 2019
| @@ -1492,6 +1492,12 @@ | |||
| githubId = 49904992; | |||
| name = "Dawid Sowa"; | |||
| }; | |||
| dbalan = { | |||
There was a problem hiding this comment.
Please do you mind splitting this change into its separate commit?
There was a problem hiding this comment.
@mmahut Thanks for taking a look, I've split the change into two commits.
Adds a new package idid to nixpkgs.
Lassulus
reviewed
Oct 25, 2019
Comment on lines
+3
to
+9
| let | ||
| version = "2.1.0"; | ||
| in | ||
|
|
||
| mkDerivation { | ||
| pname = "idid"; | ||
| inherit version; |
There was a problem hiding this comment.
you can write it like this:
mkDerivation rec {
pname = "idid";
version = "2.1.0";
|
@ajs124 told me you should package it on hackage ;) |
|
@Lassulus Thanks! I'll try to include it via hackage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new package idid to nixpkgs.
Motivation for this change
Adds a new package that I wrote and use (it was a script in my personal nix config so far)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @