New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mailspring #69027
Add mailspring #69027
Conversation
Howdy @tyrion! Apparently I missed this when I put together my own PR to add Mailspring 😅 @aanderse pointed me over here to collaborate on things if you'd like. I haven't noticed any icon issues with the package I wrote, which leads me to believe it may be something caused by using a FHS environment. I'm also on KDE, and had to enable Gnome's Keyring due to KWallet not having support for libsecret, so I included the same configuration options that existed for the Nylas Mail package |
Hola @rummik, I added you as a collaborator to my fork of nixpkgs. I think you should then be able to make changes to this PR. Feel free to do so! Anyway, I am wondering if you managed to make mailspring run without using |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/trying-and-failing-to-package-mailspring-an-electron-app/3531/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good and got it to work on Version 1.6.3 and the newest Version (1.7.8) as well.
|
||
let mailspring-deb = pkgs.stdenv.mkDerivation rec { | ||
name = "mailspring-deb"; | ||
version = "1.6.3"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newest Version is 1.7.8 with hash 1kh5q5jhbjyfn9rxinwsnfm6v6dmjh8xrra8p2jii83d7f0vyzr0. May wanna update this
dub of #85492 (recommend to switch to this, inti for current Version) |
Yep, sorry I should have done it before. This PR can be closed in favor of #85492 |
Motivation for this change
I managed to make Mailspring run, so I am opening this PR with what I have, knowing it is incomplete (all the checkboxes below are unchecked).
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)What is missing: