Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mailspring #69027

Closed
wants to merge 1 commit into from
Closed

Add mailspring #69027

wants to merge 1 commit into from

Conversation

tyrion
Copy link

@tyrion tyrion commented Sep 18, 2019

Motivation for this change

I managed to make Mailspring run, so I am opening this PR with what I have, knowing it is incomplete (all the checkboxes below are unchecked).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

What is missing:

  • Adding a license, Mailspring advertise itself as opensource, but the mailsync engine is closed source, so I think the license should be set to unfree. Is it correct?
  • Maintainers?
  • Icons are missing from the "save attachment" dialogs (an maybe others). I suspect we need to set some environment variables, but I am not sure. Maybe someone can help. To me this is not such big issue.

@rummik
Copy link
Contributor

rummik commented Sep 25, 2019

Howdy @tyrion! Apparently I missed this when I put together my own PR to add Mailspring 😅 @aanderse pointed me over here to collaborate on things if you'd like.

I haven't noticed any icon issues with the package I wrote, which leads me to believe it may be something caused by using a FHS environment. I'm also on KDE, and had to enable Gnome's Keyring due to KWallet not having support for libsecret, so I included the same configuration options that existed for the Nylas Mail package

@tyrion
Copy link
Author

tyrion commented Sep 29, 2019

Hola @rummik, I added you as a collaborator to my fork of nixpkgs. I think you should then be able to make changes to this PR. Feel free to do so!
For example adding gnome-keyring as an explicit dependency would be great. I just didn't figure out how to do it last time.

Anyway, I am wondering if you managed to make mailspring run without using buildFHSUserEnv. In that case I think your approach might be a better place to start from.

@toschmidt toschmidt mentioned this pull request Apr 18, 2020
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/trying-and-failing-to-package-mailspring-an-electron-app/3531/2

Copy link
Contributor

@tobkratz tobkratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good and got it to work on Version 1.6.3 and the newest Version (1.7.8) as well.


let mailspring-deb = pkgs.stdenv.mkDerivation rec {
name = "mailspring-deb";
version = "1.6.3";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newest Version is 1.7.8 with hash 1kh5q5jhbjyfn9rxinwsnfm6v6dmjh8xrra8p2jii83d7f0vyzr0. May wanna update this

@tobkratz
Copy link
Contributor

dub of #85492 (recommend to switch to this, inti for current Version)

@tyrion
Copy link
Author

tyrion commented Jun 18, 2020

Yep, sorry I should have done it before. This PR can be closed in favor of #85492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants