Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrast: init at 0.0.2 #69030

Merged
merged 1 commit into from
Oct 31, 2019
Merged

contrast: init at 0.0.2 #69030

merged 1 commit into from
Oct 31, 2019
+73 −0

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Sep 18, 2019

Contrast level checking for GNOME.

Homepage: https://gitlab.gnome.org/World/design/contrast

  • Tested on NixOS with sandboxing enabled

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package labels Sep 18, 2019
@ofborg ofborg bot requested review from worldofpeace and hedning September 18, 2019 15:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 18, 2019
@ofborg ofborg bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Sep 18, 2019
worldofpeace
worldofpeace reviewed Sep 18, 2019
View reviewed changes
pkgs/applications/accessibility/contrast/default.nix Outdated
{ stdenv
, fetchFromGitLab
, cairo
, cargo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, cargo

dtzWill
dtzWill suggested changes Sep 18, 2019
View reviewed changes
Copy link
Member

@dtzWill dtzWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits/suggestions.

worldofpeace
worldofpeace approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished that up and rebased it for you 👍

@worldofpeace worldofpeace merged commit e26c2ba into NixOS:master Oct 31, 2019
@worldofpeace worldofpeace deleted the contrast branch October 31, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill

@worldofpeace worldofpeace

@hedning hedning

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @dtzWill @worldofpeace