Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/pantheon: use Pantheon's greeter #68729

Merged
merged 7 commits into from Sep 18, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Sep 14, 2019

Motivation for this change

This depends on #68492 to work.
Literally took months of fishing around for this to work properly on NixOS 馃ぃ (elementary/greeter#318)

elementary greeter 5.0 Release Notes

Users of Pantheon defaults in NixOS won't nudge into #60651 issue anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace added this to In progress in Pantheon via automation Sep 14, 2019
@worldofpeace worldofpeace self-assigned this Sep 14, 2019
@worldofpeace worldofpeace merged commit 760b677 into NixOS:master Sep 18, 2019
Pantheon automation moved this from In progress to Done Sep 18, 2019
@worldofpeace worldofpeace deleted the elementary-greeter/master branch September 18, 2019 15:16
@tobiasBora
Copy link
Contributor

tobiasBora commented Sep 27, 2019

Would it be possible to move these changes to release branch 19.09 as well? I'm affected by #60651 but for now when I manually enable the pantheon gtk's greater for lightdm (I'm using xfce as DE), I get a warning:

trace: warning: The Pantheon greeter is suboptimal in NixOS and can possibly put you in
a situation where you cannot start a session when switching desktopManagers.

Thanks!

@worldofpeace
Copy link
Contributor Author

That's a difficult situation because I had to change the global environment in a substantial way for this to work properly #68492.

That particular change isn't safe for a backport. I could adapt this change so we can have it in 19.09.
It's something I will consider as I don't want to sacrifice user experience.

@tobiasBora
Copy link
Contributor

Ok thanks, let me know if you integrate it at some points!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pantheon
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants