Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appimageTools: add at-spi2-core to multiPkgs #68873

Merged
merged 1 commit into from Sep 17, 2019
Merged

appimageTools: add at-spi2-core to multiPkgs #68873

merged 1 commit into from Sep 17, 2019
+1 −0

Conversation

ghost
Copy link

@ghost ghost commented Sep 16, 2019

Motivation for this change

There are multiple AppImage applications which require libat* libraries even though the exclude list doesn't mention them.

This fixes #68267.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tilpner

worldofpeace
worldofpeace approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, already has at-spi2-atk.

@FRidh
Copy link
Member

FRidh commented Sep 16, 2019

Are we just accepting bad packaging instead of pushing upstreams to fix their builds? I can see the practical reasons for doing this, but we should spend at least some effort I think towards informing upstreams.

@FRidh
Copy link
Member

FRidh commented Sep 16, 2019

Also, see the comments in the file that is edited. If we add additional libraries, don't add them to the main list because its no longer clear which ones are expected and which not.

@worldofpeace
Copy link
Contributor

@FRidh From previous discussions I've seen on this exact situation appearing upstream didn't really have a "taste" for it. Perhaps they don't declare at-spi2-core because at-spi2-atk depends on it so it gets pulled in on impure environments.

@ghost
Copy link
Author

ghost commented Sep 16, 2019 •
edited by ghost

I put at-spi2-atk below libtool.lib.

@worldofpeace worldofpeace merged commit 7d16370 into NixOS:master Sep 17, 2019
@ghost ghost deleted the appimage-tools-libatspi branch September 18, 2019 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

appimage-run can't run pennywise
3 participants
@FRidh @worldofpeace @tilpner