Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evcxr: 0.4.4 -> 0.4.5 #68941

Merged
merged 1 commit into from Sep 17, 2019
Merged

evcxr: 0.4.4 -> 0.4.5 #68941

merged 1 commit into from Sep 17, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 16, 2019 •
edited

Motivation for this change

New release: https://github.com/google/evcxr/blob/v0.4.5/RELEASE_NOTES.md#version-045

Also added myself as maintainer and removed zeromq from the build
inputs as it's now vendored by upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @protoben

@Ma27
evcxr: 0.4.4 -> 0.4.5
af564fb 
New release: https://github.com/google/evcxr/blob/v0.4.5/RELEASE_NOTES.md#version-045

Also added myself as maintainer and removed `zeromq` from the build
inputs as it's now vendored by upstream.
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 16, 2019
@worldofpeace worldofpeace merged commit 0c9fab9 into NixOS:master Sep 17, 2019
@worldofpeace
Copy link
Contributor

backported in 3109b42

@Ma27 Ma27 deleted the bump-evcxr branch September 17, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @worldofpeace