More GHC8.8.1 fixes #68935
Merged
More GHC8.8.1 fixes #68935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
September 15, 2019 21:13
…t_1_0_7" This reverts commit 5e91bfa.
cdepillabout
approved these changes
Sep 16, 2019
|
@luc-tielen Also, could you edit the message for this PR (this) and put in the text "Fix #68879" somewhere so that #68879 is automatically closed when this PR is merged in? |
alexarice
reviewed
Sep 16, 2019
pkgs/development/haskell-modules/patches/alex-3.2.4-ghc8.8.x.patch
Outdated
Show resolved
Hide resolved
|
@alexarice Good catch with the |
|
@GrahamcOfBorg eval |
cdepillabout
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
@luc-tielen Thanks for working on this.
I tried compiling all the packages touched in this PR with the following command:
$ nix-build -E 'with (import ./. {}); haskell.packages.ghc881.ghcWithPackages (p: with p; [cabal-doctest yaml alex haskell-src-meta happy haskell-src-exts vector-th-unbox socks attoparsec vault tasty-hedgehog])'Everything compiled successfully. I also confirmed that ats-pkg could be built.
@peti This should be ready to merge.
peti
reviewed
Sep 17, 2019
|
Thanks! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I couldn't get one of my haskell projects to work with ghc881 with hoogle, so I tried fixing what I came across.
NOTE: I have never pushed to this repo before and I still consider myself to be fairly new at using nix. So feel free to point out if I did some silly stuff. 😄
Fix #68879
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @