Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

konversation: make sure breeze-icons is in buildInputs #69010

Closed
wants to merge 1 commit into from
Closed

konversation: make sure breeze-icons is in buildInputs #69010

wants to merge 1 commit into from

Conversation

cdepillabout
Copy link
Member

Motivation for this change

When running konversation, I was seeing errors like the following:

$ konversation
Icon theme "breeze" not found.
Icon theme "breeze" not found.
Error: standard icon theme "breeze" not found!

I had seen this before with okular:

#53750

It looks like the current okular derivation adds breeze-icons to buildInputs, so I thought this might be a good solution for the same problem with konversation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@ofborg ofborg bot requested a review from FRidh September 18, 2019 05:24
@cdepillabout
Copy link
Member Author

cdepillabout commented Sep 18, 2019 •
edited

@GrahamcOfBorg build konversation

edit: hmm, I wonder why ofborg didn't respond to this...

@aanderse
Copy link
Member

ping @grahamc who asked to be notified of bot continued to act up.

@worldofpeace
Copy link
Contributor

@cdepillabout Why don't you just install breeze-icons to your system?
Users of Plasma5 module will never see this issue because their system is properly configured with an icon theme.

See discussion at #43150 (comment), which it seems you were part at some point.

@cdepillabout
Copy link
Member Author

@worldofpeace Thanks for the recommendation.

When following #43150, I ended up installing gnome3.adwaita-icon-theme to my environment.systemPackages for GTK apps, but I never installed breeze-icons for QT apps. I guess I'll go ahead and do that.

@cdepillabout cdepillabout deleted the add-breeze-icons-to-konversation branch November 1, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdepillabout @aanderse @worldofpeace