Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpustat: init at 0.02.09 #68917

Merged
merged 2 commits into from Sep 17, 2019
Merged

cpustat: init at 0.02.09 #68917

merged 2 commits into from Sep 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 16, 2019

Motivation for this change

CPU usage monitoring tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Sep 16, 2019

(updated to quote homepage URL)

@dtzWill
Copy link
Member Author

dtzWill commented Sep 16, 2019

(requesting reviews from maintainers of other CK utils)

stdenv.mkDerivation rec {
pname = "cpustat";
version = "0.02.09";
src = fetchurl {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use whitespace between the attributes.

Exception is made for pname/version as is convention.
@dtzWill
Copy link
Member Author

dtzWill commented Sep 17, 2019 via email

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can view manual and run program.

@worldofpeace worldofpeace merged commit bd38743 into NixOS:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants