pythonPackages.entrance: init at 1.1.10 (and janus init at 0.4.0) #68957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonchatts
force-pushed
the
entrance
branch
from
5b841c8
to
5e2a563
Compare
simonchatts
force-pushed
the
entrance
branch
from
5e2a563
to
dfb5755
Compare
simonchatts
changed the title
|
The dependent PRs have both been merged, and I've rebased and re-tested, so this should be good to go. |
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Oct 1, 2019
pythonPackages.entrance: init at 1.1.10 (and janus init at 0.4.0) (cherry picked from commit 0df4dad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Support the entrance Python package.
Note:
entrancePython package can be installed in a "lean" default mode with minimal dependencies, or a "with-router-features" mode that adds functionality but also some fairly heavy dependencies. These are exposed as two derivations.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)The package's sample applications have been run, on both NixOS and macOS, exercising both the "lean" and "with-router-features" options.