Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp: fix darwin build #68870

Merged
merged 1 commit into from Sep 17, 2019
Merged

amp: fix darwin build #68870

merged 1 commit into from Sep 17, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Sep 15, 2019

Motivation for this change

Fix darwin build for #68361.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sbourdeauducq

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 15, 2019
@ofborg ofborg bot requested a review from sbourdeauducq September 15, 2019 22:58
sbourdeauducq
sbourdeauducq approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@sbourdeauducq sbourdeauducq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on Darwin but otherwise LGTM.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build amp

@matthewbauer matthewbauer merged commit b6ad762 into NixOS:master Sep 17, 2019
@B4dM4n B4dM4n deleted the amp-darwin branch September 18, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbourdeauducq sbourdeauducq sbourdeauducq approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @matthewbauer @sbourdeauducq