Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/release: add gnome3 closure #68987

Merged
merged 1 commit into from Sep 17, 2019
Merged

nixos/release: add gnome3 closure #68987

merged 1 commit into from Sep 17, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 17, 2019
jtojnar
jtojnar approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not see any downside. Looking at the KDE closure, the output size and build time should be negligible.

@worldofpeace worldofpeace merged commit 6bd2a8f into NixOS:master Sep 17, 2019
@worldofpeace worldofpeace deleted the closures branch September 17, 2019 21:53
@worldofpeace
Copy link
Contributor Author

backported in 76672ad

@wineee wineee mentioned this pull request May 8, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar