mle: init at 1.4.1 #68949
mle: init at 1.4.1 #68949
Conversation
|
@GrahamcOfBorg build mle |
| @@ -184,6 +184,12 @@ | |||
| githubId = 1250775; | |||
| name = "Adolfo E. García Castro"; | |||
| }; | |||
| adsr = { | |||
There was a problem hiding this comment.
The addition to maintainers.nix should be in a separate commit titled "maintainers: add adsr"
| buildInputs = [ termbox pcre uthash lua5_3 ]; | ||
|
|
||
| doCheck = true; | ||
| checkPhase = "make test"; |
There was a problem hiding this comment.
I believe this should be the default checkPhase
| }; | ||
|
|
||
| postPatch = '' | ||
| substituteInPlace Makefile --replace "-llua5.3" "-llua"; |
There was a problem hiding this comment.
Might be worth putting some motivation for these somewhere, did you create this fix yourself or is it from somewhere else
There was a problem hiding this comment.
Have just realised this is your own project, is there any reason this can't be upstreamed?
There was a problem hiding this comment.
The version in trunk (-llua5.3 / <lua5.3/lua.h>) works with Debian-based systems. Alternatives to this are using pkg-config or trying to guess the location of Lua dynamically. Personally I prefer this small patch as I find it the simplest to read.
adsr
force-pushed
the
feature/mle
branch
2 times, most recently
from
2c2ecef
to
8fef7b1
Compare
mle: init at 1.4.1 (cherry picked from commit 1cee79c)
Motivation for this change
Small, flexible, terminal-based text editor
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)