Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: use gcc8 on darwin #68998

Merged
merged 1 commit into from Sep 21, 2019
Merged

Conversation

matthewbauer
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
Copy link
Member

FRidh commented Sep 19, 2019

No intention on fixing the breakage due to switching to gcc8?

@matthewbauer
Copy link
Member Author

No intention on fixing the breakage due to switching to gcc8?

I haven't had any issues on gcc 8.3.0

@matthewbauer matthewbauer changed the base branch from master to staging September 19, 2019 15:38
@LnL7
Copy link
Member

LnL7 commented Sep 20, 2019

Any idea why haskell stuff depends on gcc? It probably shouldn't.

@matthewbauer matthewbauer merged commit 2196174 into NixOS:staging Sep 21, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 22, 2019
gcc: use gcc8 on darwin
(cherry picked from commit 2196174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants