Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.boltztrap2: fix build #68936

Merged
merged 1 commit into from Sep 17, 2019
Merged

python3Packages.boltztrap2: fix build #68936

merged 1 commit into from Sep 17, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 16, 2019 •
edited

Motivation for this change

#68361

disable cmake configure where it does cd ./build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68936
1 package were build:
python37Packages.boltztrap2

@ofborg ofborg bot requested a review from costrouc September 16, 2019 20:02
@lsix
Copy link
Member

lsix commented Sep 17, 2019

Built and tested.

Thanks.

@lsix lsix merged commit f772fe5 into NixOS:master Sep 17, 2019
@lsix
Copy link
Member

lsix commented Sep 17, 2019

in release-19.09 as e228f3f

@jonringer jonringer deleted the fix-boltz branch September 18, 2019 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @lsix