[webnfc] Add tests for NFCPushOptions.ignoreRead #19082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1804324
branch
2 times, most recently
from
929d925
to
04d8e20
Compare
Covered two checkpoints: - Existing data should be read during the same tap if NFCPushOptions.ignoreRead is set to false. - Existing data should not be read during the same tap if NFCPushOptions.ignoreRead is set to true. Fixed bug in "setReadingMessage" func in external/wpt/resources/chromium/nfc-mock.js that |message| is of type NDEFMessageInit should have no compatibility and message properties. BUG=520391 Change-Id: I6fdc69ff96008142d179a801008e04e7979d6112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804324 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Leon Han <leon.han@intel.com> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#697102}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1804324
branch
from
04d8e20
to
06015e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covered two checkpoints:
is set to false.
is set to true.
Fixed bug in "setReadingMessage" func in external/wpt/resources/chromium/nfc-mock.js
that |message| is of type NDEFMessageInit should have no compatibility and message
properties.
BUG=520391
Change-Id: I6fdc69ff96008142d179a801008e04e7979d6112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804324
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Leon Han <leon.han@intel.com>
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Cr-Commit-Position: refs/heads/master@{#697102}