Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Allow overflow-/word-wrap to work with keep-all #19081

Merged
merged 1 commit into from Sep 16, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 16, 2019

When word-break: break-all or keep-all is specified, this
patch fixes overflow-/word-wrap: break-word to be effective.

Before this patch, it was forced to be normal.

Bug: 1001378
Change-Id: I73f5956a6856f2cbd0944461a0aa7a2929e722cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806162
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696724}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

When `word-break: break-all` or `keep-all` is specified, this
patch fixes `overflow-/word-wrap: break-word` to be effective.

Before this patch, it was forced to be `normal`.

Bug: 1001378
Change-Id: I73f5956a6856f2cbd0944461a0aa7a2929e722cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806162
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696724}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants