Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmind: fix shell escape #68993

Merged
merged 1 commit into from Sep 18, 2019
Merged

xmind: fix shell escape #68993

merged 1 commit into from Sep 18, 2019

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

This fixes a bug in which a missing shell escape led to XMing trying to load the working directory as a document when starting up, causing slow-downs and error messages.

Things done

Added shell escape.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @michalrus @Ma27

@Ma27
Copy link
Member

Ma27 commented Sep 18, 2019

oof good catch! Will test locally and report back! :)

@Ma27 Ma27 self-assigned this Sep 18, 2019
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 18, 2019
@ofborg ofborg bot requested a review from Ma27 September 18, 2019 00:26
@Ma27 Ma27 merged commit 17fb9ff into NixOS:master Sep 18, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 18, 2019

Thanks! Backported as 44808be

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 18, 2019
@elohmeier elohmeier deleted the xmind branch September 29, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees

@Ma27 Ma27

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elohmeier @Ma27