Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qbec: init at 0.7.5 #68717

Merged
merged 1 commit into from
Sep 18, 2019
Merged

qbec: init at 0.7.5 #68717

merged 1 commit into from
Sep 18, 2019
+24 −0

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Sep 13, 2019 •
edited
Loading

Motivation for this change

Configure kubernetes objects on multiple clusters using jsonnet https://qbec.io
Version: qbec v0.7.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 13, 2019
@ofborg ofborg bot requested a review from kalbasit September 13, 2019 23:55
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 13, 2019
@groodt
Copy link
Contributor Author

groodt commented Sep 17, 2019

Thanks for the review @worldofpeace

@groodt groodt requested a review from worldofpeace September 17, 2019 23:27
worldofpeace
worldofpeace approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this program try to call into any executables that are expected to be in PATH?
That's a common thing with cli tools.

@groodt
Copy link
Contributor Author

groodt commented Sep 17, 2019

Does this program try to call into any executables that are expected to be in PATH?

Not by default. There is experimental support for "helm" where it uses os/exec to shell out to "helm" which makes it non-hermetic, but for the core supported functionality, it is self-contained.

If "helm" becomes an issue in future, I imagine it could be integrated through libraries in the upstream project, or it can be solved in nixpkgs with patches or by adding dependencies.

@worldofpeace
Copy link
Contributor

Does this program try to call into any executables that are expected to be in PATH?

Not by default. There is experimental support for "helm" where it uses os/exec to shell out to "helm" which makes it non-hermetic, but for the core supported functionality, it is self-contained.

If "helm" becomes an issue in future, I imagine it could be integrated through libraries in the upstream project, or it can be solved in nixpkgs with patches or by adding dependencies.

Excellent. Usually for things like with helm we could wrap the executable with a shell script that adds an entry to PATH, or hardcode it within the source.

@worldofpeace worldofpeace merged commit 327c52e into NixOS:master Sep 18, 2019
@groodt groodt deleted the groodt-qbec-0.7.5 branch September 18, 2019 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@kalbasit kalbasit

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@groodt @worldofpeace