Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/moodle: add extraConfig option #68891

Merged
merged 1 commit into from Sep 17, 2019
Merged

nixos/moodle: add extraConfig option #68891

merged 1 commit into from Sep 17, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

Missed this as an oversight of initial moodle module, required in many cases to add often required configuration to the service. Definitely needs backport to 19.09 for the module to be of any practical use, and safe to do so because very non-impacting change (simply adds an option).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse aanderse added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 16, 2019
@aanderse aanderse requested a review from etu September 16, 2019 12:59
@etu etu merged commit c45bf10 into NixOS:master Sep 17, 2019
@aanderse aanderse deleted the moodle branch September 17, 2019 10:22
@aanderse aanderse mentioned this pull request Sep 17, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @etu