Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coz: init at 0.2.0 #68981

Merged
merged 1 commit into from Oct 3, 2019
Merged

coz: init at 0.2.0 #68981

merged 1 commit into from Oct 3, 2019

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 17, 2019 •
edited

Motivation for this change

profiling nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@zimbatm zimbatm changed the title coz-profiler: init at 0.2.0 coz: init at 0.2.0 Sep 17, 2019
@dtzWill dtzWill mentioned this pull request Oct 2, 2019
Closed
@tobim
Copy link
Contributor

tobim commented Oct 2, 2019

I would suggest to build the viewer as well (https://github.com/plasma-umass/coz/tree/master/viewer).

tobim
tobim suggested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: For some reason include/coz.h is marked as executable in the store.

Maybe the accompanying viewer should be built as well, I don't know how useful this is without it.

pkgs/development/tools/analysis/coz/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/analysis/coz/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/analysis/coz/default.nix Outdated Show resolved Hide resolved
@zimbatm
Copy link
Member Author

zimbatm commented Oct 3, 2019

Thanks @tobim for your review. I need to use coz a bit before this is ready to be merged.

coz is currently not able to find libcoz.so. This is already fixed in master upstream so I'll just wait for a new release.

@zimbatm

This comment has been minimized.

Sign in to view
@zimbatm zimbatm merged commit d3542aa into NixOS:master Oct 3, 2019
@zimbatm zimbatm deleted the coz-0.2.0 branch October 3, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim requested changes

@wykurz wykurz wykurz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @tobim @wykurz