Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnvim: init at 0.1.5 #69020

Merged
merged 1 commit into from Oct 2, 2019
Merged

gnvim: init at 0.1.5 #69020

merged 1 commit into from Oct 2, 2019

Conversation

minijackson
Copy link
Member

Motivation for this change

Gnvim a rich Neovim GUI without any web bloat

Based on the neovim-qt derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

teto
teto requested changes Sep 18, 2019
View reviewed changes
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool that you can arbitrarily set the version (unlike me fetching tags https://github.com/teto/home/blob/master/config/nixpkgs/overlays/pkgs/gnvim/default.nix).
The wrapper should be in another file so that one can override the unwrapped version.

@minijackson
Copy link
Member Author

@teto I think so too, so should we change the neovim-qt derivation to have a separate unwrapped package? Neovim has quite a lot of GUIs, so it would be nice to have a consistent structure.

I didn't know of the leaveDotGit parameter, nice to know!

(Also, damn you are fast)

@teto
Copy link
Member

teto commented Sep 18, 2019 •
edited

(Also, damn you are fast)

damn, I hear that a lot but only from girls so far !

would be cool to do it for neovim-qt as well but in a separate PR, let's focus :)

@minijackson
Copy link
Member Author

Should be good now ^^

@teto
Copy link
Member

teto commented Sep 30, 2019

@GrahamcOfBorg build gnvim

@teto
Copy link
Member

teto commented Sep 30, 2019

nix-review builds it fine but at runtime I get
GnvimScroll error: NeovimError(0, "Vim(call):E117: unknown function : gnvim#cursor_tooltip#hide")
echo $GNVIM_RUNTIME_PATH returned nothing, you might need to add it to the wrapper as explained in the README.

@minijackson
Copy link
Member Author

Good catch! It also made me realize that the .desktop in the wrapper was still pointing to the unwrapped binary. Gnvim works even better for me now, with all the good pretty colors!

teto
teto approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok apart from the remaining comment.

@teto
Copy link
Member

teto commented Oct 2, 2019

@GrahamcOfBorg build gnvim

@teto teto merged commit 4e7364a into NixOS:master Oct 2, 2019
@teto
Copy link
Member

teto commented Oct 2, 2019

Thanks for maintaining this. I wanted in it nixpkgs but didn't have the courage to put myself as a maintainer xD

@minijackson minijackson deleted the init-gnvim branch September 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minijackson @teto