Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bingrep: init at 0.7.0 #69021

Merged
merged 1 commit into from Sep 22, 2019
Merged

bingrep: init at 0.7.0 #69021

merged 1 commit into from Sep 22, 2019

Conversation

minijackson
Copy link
Member

Motivation for this change

bingrep: Greps through binaries from various OSs and architectures, and colors them.

Subject to name change in the future.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@minijackson
Copy link
Member Author

minijackson commented Sep 18, 2019

That's weird, it compiles just fine for me from master (tested from my fork, and with nox-review)

@minijackson
Copy link
Member Author

Yep, tested it again with nox-review on another computer, in case my vendored dependencies where somehow invalidated, and compiles just fine ^^

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build bingrep

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the above change this should be good to merge.
I've already tested execution on NixOS x86_64-linux.

@zimbatm zimbatm merged commit 20de448 into NixOS:master Sep 22, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 22, 2019
@minijackson minijackson deleted the init-bingrep branch September 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants