chromium: add patch to fix performance regression with fonts #68991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a commit to fix a serious performance regression introduced in Chromium 77: https://bugs.chromium.org/p/chromium/issues/detail?id=1003997
ivan
force-pushed
the
chromium-77-font-fix
branch
from
6fcae19
to
19d730d
Compare
|
Updated to use |
|
Chromium author says "NOTE: It is SAFE to revert that CL on Stable or any channels to fix the issue." https://bugs.chromium.org/p/chromium/issues/detail?id=1003997#c13 |
10 tasks
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Oct 24, 2019
chromium: add patch to fix performance regression with fonts (cherry picked from commit a81f830)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes a font-related performance regression in Chromium 77: https://bugs.chromium.org/p/chromium/issues/detail?id=1003997
The issue can be very annoying, with 4.5 second pauses and an inability to scroll through bookmark folders.
It is not clear exactly which fonts (or how many) need to be installed to see this problem, but I reverted the relevant commit and confirmed that this fixed the issue in
chromium,chromiumBeta, andchromiumDev.The reverted commit appears to be self-contained and not related to any security bugs. This patch will be hopefully be removed by the time Chromium 78 is released.
If accepted to master, please also cherry-pick to release-19.09.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @bendlas
and previous committers @andir @samueldr