Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: Update version to 1.13 #68810

Closed
wants to merge 1 commit into from
Closed

go: Update version to 1.13 #68810

wants to merge 1 commit into from

Conversation

c00w
Copy link
Contributor

@c00w c00w commented Sep 14, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from velovix, Mic92 and cstrahan September 14, 2019 18:16
@c00w c00w force-pushed the go_1_13 branch 4 times, most recently from 05efa0c to fd0fec3 Compare September 14, 2019 21:57
@c00w c00w changed the title WIP go: Update version to 1.13 go: Update version to 1.13 Sep 14, 2019
@rvolosatovs
Copy link
Member

rvolosatovs commented Sep 16, 2019 •
edited

Duplicate of #68135
The update breaks a couple of packages(see #68135 (comment))
Maybe you want to contribute to help fixing some?

4z3
4z3 reviewed Sep 16, 2019
View reviewed changes
pkgs/development/compilers/go/1.12.nix
@@ -30,11 +30,11 @@ in

stdenv.mkDerivation rec {
pname = "go";
version = "1.12.9";
version = "1.13";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep both 1.12 and 1.13 around for a while, as both considered stable upstream at the moment. If we really want to keep only 1.13, then we should at least reflect that in the file name (it's currently called 1.12.nix), and we should also rename the attributes go_1_12 and buildGo112* in pkgs/all-packages/top-level.nix.

@c00w
Copy link
Contributor Author

c00w commented Sep 17, 2019

Ack - for some reason my searching didn't spot the go1.13 PR - closing in favor of getting that to work.

@c00w c00w closed this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4z3 4z3 4z3 left review comments

@velovix velovix Awaiting requested review from velovix

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c00w @rvolosatovs @4z3