Various cross-compilation fixes #68889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
fpletz,
peti,
vrthra,
JohnAZoidberg and
ttuegel
| @@ -57,7 +57,7 @@ stdenv.mkDerivation rec { | |||
| preConfigure = "NOCONFIGURE=1 ./autogen.sh"; | |||
|
|
|||
| configureFlags = [ | |||
| "--enable-gtk-doc" | |||
| "--${if stdenv.buildPlatform == stdenv.hostPlatform then "enable" else "disable"}-gtk-doc" | |||
There was a problem hiding this comment.
I think lib.enableFeature (stdenv.buildPlatform == stdenv.hostPlatform) "gtk-doc" would to the same thing?
There was a problem hiding this comment.
You're right - fixed.
dtc's build system does not support cross-compilation of its swig-generated python bindings.
nspin
force-pushed
the
pr/various-cross-2
branch
from
fa1e17a
to
35f39ac
Compare
fpletz
approved these changes
Sep 17, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes cross-compilation for:
pinentrygnupgudisks2dtcThings done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @