haskell-hakyll: add missing files, remove obsolete patch #68990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update was generated by hackage2nix v2.14.4-7-ga804c35 from Hackage revision commercialhaskell/all-cabal-hashes@eff4b5a.
This update was generated by hackage2nix v2.14.4-7-ga804c35 from Hackage revision commercialhaskell/all-cabal-hashes@9d05e8f.
This update was generated by hackage2nix v2.14.4-7-ga804c35 from Hackage revision commercialhaskell/all-cabal-hashes@ab7669c.
This update was generated by hackage2nix v2.14.4-7-ga804c35 from Hackage revision commercialhaskell/all-cabal-hashes@cb17dc2.
haskellPackages.massiv: mark unbroken
This update was generated by hackage2nix v2.14.4-7-ga804c35 from Hackage revision commercialhaskell/all-cabal-hashes@2bf5280.
This reverts commit fe366d4.
Can be reverted, when jaspervdj/hakyll#732 makes in into a release.
peti
force-pushed
the
haskell-updates
branch
4 times, most recently
from
d075238
to
742348d
Compare
|
Hakyll 4.13.0.1 is out. |
|
Ok, I'll close this and reopen with the removal of the outdated patch, as it currently blocks the build. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unbreak the build.
Things done
As the Hackage tarball does not contain all files from the git repo (which is hopefully fixed with jaspervdj/hakyll#732), I manually pulled in two missing files from the newest release. Also I removed an unnecessary patch.
I guess it doesn't really make sense to merge this, as jaspervdj/hakyll#732 will be merged soon probably and we can wait for the next release from upstream. I did this patch more for myself to see wether I fixed the issue. Maybe anyone else wants to use this to temporarily fix their issue with hakyll.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @