Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helmfile: 0.79.3 -> 0.85.0 #68943

Merged
merged 1 commit into from Sep 17, 2019
Merged

helmfile: 0.79.3 -> 0.85.0 #68943

merged 1 commit into from Sep 17, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update
Blocking #68135

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pneumaticat @yurrriq

@rvolosatovs rvolosatovs mentioned this pull request Sep 16, 2019
Merged
10 tasks
@kliu128
Copy link

kliu128 commented Sep 16, 2019

I get a sha256 mismatch for go-modules:

hash mismatch in fixed-output derivation '/nix/store/n8rs0y7gdsk7856x9b7igagbfr98a83f-helmfile-0.85.0-go-modules':
  wanted: sha256:1gb28v7l6syyplfmamg2f8k096iwzglh2drh4djlx131cyxxwxa1
  got:    sha256:1npjm3rs32c1rwx8xb9s03jhd156da6p66hpaqccm7b6zxsm32nv

Should I also build with Go 1.13?

@rvolosatovs
Copy link
Member Author

I'm starting to think it's somehow related to go 1.13 🤔

@rvolosatovs
Copy link
Member Author

@Pneumaticat updated the hash

@kliu128
Copy link

kliu128 commented Sep 16, 2019

Builds and works for me now 👍

@yurrriq
Copy link
Member

yurrriq commented Sep 17, 2019

Thanks!

@Mic92 Mic92 merged commit b0d5098 into NixOS:master Sep 17, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 17, 2019

@rvolosatovs could be. Maybe you can diff it between both go versions. Would be terrible though and we should fix this.

@yurrriq
Copy link
Member

yurrriq commented Sep 17, 2019

I wonder if that's the issue I run into periodically..

@rvolosatovs rvolosatovs deleted the update/helmfile branch September 17, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurrriq yurrriq yurrriq approved these changes

@kliu128 kliu128 Awaiting requested review from kliu128

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvolosatovs @kliu128 @yurrriq @Mic92