Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

station: init at 1.51.1 #69007

Merged
merged 2 commits into from Oct 3, 2019
Merged

station: init at 1.51.1 #69007

merged 2 commits into from Oct 3, 2019
+38 −0

Conversation

ghost
Copy link

@ghost ghost commented Sep 18, 2019

Motivation for this change

This PR adds station package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 18, 2019
jonringer
jonringer approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable works
leaf package

mmahut
mmahut reviewed Sep 19, 2019
View reviewed changes
maintainers/maintainer-list.nix
@@ -3493,6 +3493,12 @@
github = "Lassulus";
name = "Lassulus";
};
lattfein = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind splitting this change into a separate commit please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I've split the change into two commits.

@ghost ghost requested a review from mmahut September 20, 2019 09:03
@ghost
Copy link
Author

ghost commented Sep 27, 2019

@mmahut station has been updated to 1.51.1 recently. Should I update this PR before merge or open another PR after merge?

@jonringer
Copy link
Contributor

i would just update this pr, you can also edit the title

Koki Yasuno added 2 commits September 27, 2019 13:26
maintainers: add lattfein

Unverified

No user is associated with the committer email.
Learn about vigilant mode
ee3521b
station: init at 1.51.1

Unverified

No user is associated with the committer email.
Learn about vigilant mode
aefa34f
@ghost ghost changed the title station: init at 1.49.0 station: init at 1.51.1 Sep 27, 2019
@ghost
Copy link
Author

ghost commented Sep 27, 2019

Updated to 1.51.1.

@ghost
Copy link
Author

ghost commented Oct 3, 2019

What is the state of this PR? I've been using station at work without any problems. Is there anything I can do?

jonringer
jonringer approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ran nix-review, passes on NixOS
diff LGTM (but not super familiar with appImage packaging)
executable seems to work
leaf packge

[10 built, 34 copied (46.9 MiB), 12.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69007
1 package were build:
station

@jonringer jonringer merged commit 45e3058 into NixOS:master Oct 3, 2019
@ghost ghost deleted the station-init branch October 3, 2019 10:02
grahamc added a commit that referenced this pull request Dec 24, 2019
@grahamc
maintainer list: lattfein account was deleted

Verified

This commit was signed with the committer’s verified signature. The key has expired.
grahamc Graham Christensen
GPG key ID: FE918C3A98C1030F
Expired
Verified
Learn about vigilant mode
0afebfe 
See: #69007 where this was added
but is now owned by a ghost.

Possibly the username lattfein (currently github ID 56827487) is
owned by the same person, but we should confirm before adding the
GitHub ID back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mmahut