Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosquitto: 1.6.4 -> 1.6.5 #68877

Merged
merged 2 commits into from Sep 17, 2019
Merged

mosquitto: 1.6.4 -> 1.6.5 #68877

merged 2 commits into from Sep 17, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Fixes #68588

We re-introduce libwebsockets 3.1.0 for now (can also be used by others of course) and compile mosquitto against that.

From my understanding of the libwebsockets changes, 3.1 -> 3.2 is bound to have caused problems elsewhere but we leave libwebsockets to refer to libwebsockets_3_2 for now.

Thanks for the explanation @ralight!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @veprbl

@peterhoeg peterhoeg merged commit fbd23c6 into NixOS:master Sep 17, 2019
@peterhoeg peterhoeg deleted the u/mqtt branch September 17, 2019 02:40
@evanjs
Copy link
Member

evanjs commented Sep 17, 2019

With cmake in nativeBuildInputs for lws, as it should be!
Thank you!

@peterhoeg peterhoeg restored the u/mqtt branch September 17, 2019 05:25
@peterhoeg peterhoeg deleted the u/mqtt branch September 17, 2019 06:34
@peterhoeg peterhoeg restored the u/mqtt branch September 17, 2019 08:39
@peterhoeg peterhoeg deleted the u/mqtt branch September 24, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libwebsockets 3.2.0 breaks Mosquitto
2 participants
@peterhoeg @evanjs