Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.prox-tv: init at 3.3.0 #76640

Merged
merged 2 commits into from Jan 2, 2020
Merged

pythonPackages.prox-tv: init at 3.3.0 #76640

merged 2 commits into from Jan 2, 2020

Conversation

multun
Copy link
Member

@multun multun commented Dec 29, 2019 •
edited

Motivation for this change

I needed it, I packaged it, let's share it!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 76640 1

3 package built:
  • python27Packages.prox-tv
  • python37Packages.prox-tv
  • python38Packages.prox-tv

jonringer
jonringer reviewed Dec 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/prox-tv/dependencies.patch Outdated Show resolved Hide resolved
@multun multun mentioned this pull request Dec 30, 2019
Closed
@FRidh FRidh merged commit f85aff5 into NixOS:master Jan 2, 2020
@jonringer jonringer mentioned this pull request Jan 6, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@multun @jonringer @FRidh