Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pynagsystemd: init at 1.2.0 and dependencies #76641

Merged
merged 2 commits into from Jan 3, 2020
Merged

pynagsystemd: init at 1.2.0 and dependencies #76641

merged 2 commits into from Jan 3, 2020

Conversation

symphorien
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Dec 29, 2019
View reviewed changes
pkgs/development/python-modules/nagiosplugin/default.nix Outdated
sha256 = "1vr3zy0zfvbrqc4nf81zxv4gs2q82sv5sjamdm4573ld529mk2nv";
};

buildInputs = [ twine ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is twine used? We basically never add Python modules as buildInputs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a build time dependency only: https://github.com/mpounsett/nagiosplugin/blob/master/requirements_build.txt

@jonringer
Copy link
Contributor

please squash the commits into the related package commit

@symphorien @jonringer
pynagsystemd: init at 1.2.0
d22164b 
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@symphorien
Copy link
Member Author

done

jonringer
jonringer approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

[6 built, 113 copied (514.2 MiB), 118.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76641
3 package were built:
pynagsystemd python37Packages.nagiosplugin python38Packages.nagiosplugin

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pynagsystemd python37Packages.nagiosplugin python38Packages.nagiosplugin

@jonringer
Copy link
Contributor

arm failures unrelated to PR

@jonringer jonringer merged commit b40fc3a into NixOS:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @jonringer @FRidh