nixos/lib: Inherit type for doRename options #76670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
requested changes
Jan 1, 2020
| @@ -717,12 +717,15 @@ rec { | |||
| fromOpt = getAttrFromPath from options; | |||
| toOf = attrByPath to | |||
| (abort "Renaming error: option `${showOption to}' does not exist."); | |||
| toType = let opt = attrByPath to {} options; in if opt ? "type" then opt.type else null; | |||
There was a problem hiding this comment.
Suggested change
| toType = let opt = attrByPath to {} options; in if opt ? "type" then opt.type else null; | |
| toType = let opt = attrByPath to {} options; in opt.type or null; |
|
Other than that this looks like a good idea |
1 task
|
Superseded by #78135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#76184
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @infinisil because you really know a lot about modules